restore option to compress raster #944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
perhaps still some refactoring to clean up the code a bit, but first want opinions on the exposed parameter. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 92.36% 92.36% -0.01%
==========================================
Files 48 48
Lines 7416 7450 +34
==========================================
+ Hits 6850 6881 +31
- Misses 566 569 +3
🚀 New features to boost your workflow:
|
Member
|
Thanks @melonora, I picked this up and merged the conflicts arising after the Zarr v3 support. The tests currently fail mainly due to the disconnect between the new format options and dask, but it should be straightforward to make the PR green again after https://github.com/ome/ome-zarr-py/pull/510/changes is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
This PR adds the capability back of using either
lz4orzstdcompression at various compression levels. It is exposed through acompressorargument inwriteandwrite_elementthat takes as value adictwith key being the compression name and the value being the compression level. By default if compression is specified bytes will be reordered for more efficient compressionSHUFFLEinblosc.